Mixed tile format doesn't work for S3 and FS
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
Research direction
Start by locating the merger paths that write tiles to FS and S3, then trace how the output file extension is selected when PNG and JPEG data are combined. Reproduce the transparency-to-no-transparency scenario from the issue. Done means the newly calculated tile replaces the existing tile rather than leaving both extensions, while remaining compatible with MapProxy serving.
Written by the indexing model from the issue text.
Description
Describe the bug
When working with files, the merger uses file extension with no regard to existing file extension. This means that if a PNG file is merged with a new JPEG resulting in a full tile (JPEG) then it will be stored and both files would exist (for the same x,y,z).
To Reproduce
- Hold a tile with transparency in FS or S3
- Update with a tile that should result in a tile with no transparency
- New tile is written next to the existing tile
Expected behavior
Only the new calculated tile should exist.
Additional context
To combat this mapproxy uses .mixed extension, this way at the end the correct data would be placed. This is because the file extension isn't needed for discovering the tile format (can be understood from tile data).
If we implement the same strategy then we will be able to use mixed format with Mapproxy serving as well.
- Dominant language
- C#
- Stars
- 1
- Forks
- 2
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MapColonies/GpkgMerger
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 25/100
MapColonies/GpkgMerger#172 ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
MapColonies/GpkgMerger#168 ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
MapColonies/GpkgMerger#159 ·
-
enhancement
MapColonies/GpkgMerger#155 · 1 assignee ·
-
Feature Testing
Difficulty 4/5 3-5 days Newbie friendliness 25/100
MapColonies/GpkgMerger#151 ·
All issues in MapColonies/GpkgMerger
Similar issues
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Type: enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
apache/arrow-adbc#4809 ·
-
type/automation type/tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
microsoft/vscode-azurefunctions#5197 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
microsoft/microsoft-ui-reactor#1274 ·