Connection secrets displayed in clear text in logs

Open
#1,152 0 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
postgresql, python
Domain
databases, security

Research direction

Start by tracing how ConnectionParameters is represented when the "remaining connection slots are reserved for" error is logged. Check the existing logging and error-handling coverage, then add regression coverage showing that the password is no longer displayed in clear text while the useful connection details remain available.

Written by the indexing model from the issue text.

Description

Hi,

When i have this error : 'remaining connection slots are reserved for', the password is displayed in clear text in the logs:
ConnectionParameters(user='<user>', password='<password>', ...

The usage of SecretStr(pydantic) or something equivalent will solve the issue

Dominant language
Python
Stars
8.1k
Forks
469
Avg merge
2d 20h
Merged PRs (30d)
9

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MagicStack/asyncpg

All issues in MagicStack/asyncpg

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.