Possibility to also furnish an openmp based build

Open
#99 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
shell
Domain
build-system

Research direction

Start in tools/build_openblas.sh at line 91, where the OpenBLAS build variable is identified. Check how the current pthread build is produced and whether an OpenMP variant can be added without replacing it. Done means the project produces a usable OpenMP-based build in addition to the existing build and avoids the reported OpenMP warnings.

Written by the indexing model from the issue text.

Description

Since #87 and #88 seems to want to make an easier to use package for public use, I was also wondering if it would be possible to build in addition an openmp build? This is just changing a variable here https://github.com/MacPython/openblas-libs/blob/master/tools/build_openblas.sh#L91 and is already the official default for the homebrew version https://formulae.brew.sh/formula/openblas

It's also available in cent os 7 and recent ubuntus as both a pthread and openmp version, so I'd guess that any old issue where it used to hang is now fixed. Currently, using these libs made with pthread under another program which would use openmp simply spams the terminal with a lot of warnings asking to rebuild openblas with openmp support, making it unusable and much, much slower. Just a suggestion that any other public project wanting to use this and openmp is currently unable to do so because of this issue.

Dominant language
Shell
Stars
17
Forks
25
Avg merge
7h 10m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MacPython/openblas-libs

All issues in MacPython/openblas-libs

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.