Make sure manylinux and macOS builds strip the binary
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- shell
- Domain
- build-system
Research direction
Start by comparing tools/build_steps.sh with configure_build.sh, especially the existing STRIP_FLAGS handling. Run the manylinux and macOS build paths and inspect whether the produced binaries retain unnecessary symbols and whether their sizes decrease. Done means both builds strip the binaries without breaking the build.
Written by the indexing model from the issue text.
Description
Once upon a time, we used more of multibuild in the openblas build process. That would pull in the STRIP_FLAGS from configure_build.sh. At some point that got left behind. I am not sure we are using the correct link arguments to strip the binaries, resulting in shipping uneccessary symbols. We should revisit adding -Wl,-strip-all to the CFLAGS in tools/build_steps.sh. As mentioned in numpy/numpy#29928, the windows was handled in #175.
This will reduce the size of the binary from ~24MB to ~23MB.
- Dominant language
- Shell
- Stars
- 17
- Forks
- 25
- Avg merge
- 7h 10m
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MacPython/openblas-libs
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
MacPython/openblas-libs#261 · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
MacPython/openblas-libs#231 · 13 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
MacPython/openblas-libs#228 · 6 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
MacPython/openblas-libs#224 · 9 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
MacPython/openblas-libs#211 · 7 comments ·
All issues in MacPython/openblas-libs
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
huggingface/Repo2RLEnv#163 · 1 comment ·
-
setup tools wizard offers no GitHub auth path, and setup summary doesn't recognize `gh` CLI auth Openarea/auth comp/cli P3 tool/skills type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
NousResearch/hermes-agent#121131 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
bradcypert/plum#53 ·
-
tmp_watchgod.sh exceeds the 1000-line cap; the Zone A guard helpers are a clean extraction seam Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
WingedGuardian/GENesis-AGI#2301 ·