Security Scan: stop flagging pinned hashes and test fixtures on release PRs
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- github-actions, python, typescript
Research direction
Start by inspecting the Security Scan workflow and its detect-secrets configuration, especially .secrets.baseline and the excludes described in the issue. Review the listed pinned hashes, test files, fixtures, and provider file to confirm which findings are false positives. Update the baseline or excludes as appropriate, then verify that a release PR scan reports only real findings.
Written by the indexing model from the issue text.
Description
On the 2.2.0 release PR (#2214), Security Scan (detect-secrets, run 37994261254) failed on findings that are not secrets:
- the sha256 pins in
surfsense_local/backend/modules/runtime_packs/office/pin.pyand a keyword inoffice/detect.py; surfsense_local/electron/src/main/sidecars/python.test.tsandsupervisor.test.ts;- the base64 fixtures in
surfsense_local/frontend/src/features/docx-snapshot/fixtures/; surfsense_backend/app/utils/proxy/providers/nodemaven.py:16.
None match the hook's excludes (.*/tests/.*, test_.*\.py), and the scan covers every file a release changes since main.
Done when: these are audited into .secrets.baseline or the excludes cover *.test.ts and fixtures/, so a release PR's scan shows only real findings.
- Dominant language
- Python
- Stars
- 16.3k
- Forks
- 1.6k
- Avg merge
- 9h 15m
- Merged PRs (30d)
- 254
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MODSetter/SurfSense
-
desktop
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
desktop security
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
architecture desktop documentation
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
Maintainers usually reply within 1 day
All issues in MODSetter/SurfSense
Similar issues
-
bug difficulty:2 good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
MakazhanAlpamys/Soup#1865 ·
Maintainers usually reply within 1 day
-
area: agents area: docs good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
openapi/gknowledge#23 ·
-
useless-suppression reported for deprecated-* messages that should be exemptPossibly taken @adityasinha-ghub claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
pylint-dev/pylint#11656 ·
Maintainers usually reply within 1 day
-
area:provisioning effort:S priority:P2 provider:local-libvirt risk:daytime-only status:in-progress type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
randomparity/kdive#3203 · 2 comments ·
Maintainers usually reply within 1 day
-
get() for StrEnumPossibly taken @FeJo5952 claimed this today. Opengood first issue
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
collective/icalendar#1921 · 1 comment ·
Maintainers usually reply within 1 day