Change approach for allowing `seg_name` and `seg_len` to be lists
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 48/100
Research direction
Start by inspecting LIST_FIELDS in wfdb/io/record.py around line 1675, along with the current SEGMENT_SPECS handling. The change is complete when seg_name and seg_len are handled through LIST_FIELDS and writing a MultiSegmentRecord continues to support them.
Written by the indexing model from the issue text.
Description
In https://github.com/MIT-LCP/wfdb-python/pull/514 an update was made to allow seg_name and seg_len to be lists. This is needed for writing a MultiSegmentRecord.
@bemoody , suggested an alternate approach:
But I think what we really want is, rather than changing the types in SEGMENT_SPECS, we want to add "seg_name" and "seg_len" to LIST_FIELDS (wfdb/io/record.py, line 1675.)
This issue is being opened to track implementing this alternate approach.
- Dominant language
- Jupyter Notebook
- Stars
- 853
- Forks
- 322
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MIT-LCP/wfdb-python
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
MIT-LCP/wfdb-python#568 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
MIT-LCP/wfdb-python#557 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
MIT-LCP/wfdb-python#554 ·
-
WFDB path ignored Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
MIT-LCP/wfdb-python#545 ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
MIT-LCP/wfdb-python#540 ·
All issues in MIT-LCP/wfdb-python
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
run-llama/llama_index#23199 ·
-
enhancement P3: gap query
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
jeffknupp/association#192 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
openml/openml-python#1749 ·
-
area:adapters bug engine:v2 snowflake status:triage triage type:bug v2
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100