`MulitpleSeries.remove()` should take list instead of just one label at a time

Open
#676 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
numpy, python
Domain
data

Research direction

Locate MultiSeries.remove() and read its implementation and related tests to see how it currently handles a single label. Add or update tests for removing multiple labels or indices, then check which form the existing API can support consistently. Done means one call removes the requested series and the tests pass.

Written by the indexing model from the issue text.

Description

enhancement help wanted low priority suggestions

Is your feature request related to a problem? Please describe.
Right now, .remove requires only one label at a time. In this case, I was trying to create multiple series from the original object based on a criteria stored in another list. I was trying to compute spectral slopes and encountered a lot of NaNs so wanted to remove these series from the object so I could create a map

Describe the solution you'd like
It would be nice to either pass a list of labels or a list of indices to the function to remove multiple series from the object at a time

Describe alternatives you've considered
Right now, I'm first identifying the labels from the nan indices in a numpy array, getting the labels and then removing them one by one.

Additional context

Image

Would be nice to just past the list of indices in idx_nan.

Dominant language
Python
Stars
104
Forks
36
Avg merge
1d 7h
Merged PRs (30d)
5

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

  • No Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from LinkedEarth/Pyleoclim_util

All issues in LinkedEarth/Pyleoclim_util

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.