Gradually enable deferred ESLint rules
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
Research direction
Start with eslint.config.mjs and the libresign/disabled-during-migration section, then review related issue #8051 and use the existing ESLint CLI to inspect the disabled rules. The issue calls for grouping rules into independently verifiable tasks; completion means the first group is implemented and reviewed, completed rules are enabled, required checks pass, and remaining rules are classified.
Written by the indexing model from the issue text.
Description
Goal
Complete the phased adoption of useful ESLint rules after upgrading to @nextcloud/eslint-config v9. Keep contributor work focused and reviewable without introducing runtime changes or artificial documentation.
Verified history
The original migration was #8051. The first batch of four sub-issues (#9142–#9145) has been completed through merged PRs. PR #9497 additionally proposes enabling @stylistic/no-extra-semi and must be verified before assuming that rule is enabled on main.
The libresign/disabled-during-migration section in eslint.config.mjs is the technical inventory. At the audit baseline there are 36 disabled entries on main, of which one is being addressed by #9497. The next six sub-issues cover the remaining 35 rules through five implementation workstreams and one evidence-based classification/reconciliation activity. Historical violation counts are illustrative and must be refreshed before changes.
Implementation principles
- Preserve Vue event/slot/prop contracts, API payload keys, imports with side effects, translations, runtime behavior and generated-file boundaries.
- Keep related rules in reviewable PRs, with a separate coherent DCO-signed commit per rule. Do not rewrite unrelated areas to satisfy an automatic fixer.
- When a rule conflicts with project conventions (for example, tabs in
.editorconfig), document the reason and seek a deliberate maintainer decision rather than enabling it blindly. - Review each disabled rule as actionable, deferred or intentionally disabled using measured evidence.
- Use native GitHub sub-issue relationships as the source of truth for tracking; avoid a manually synchronized child checklist.
- Reserve
good first issuefor tasks truly suitable for newcomers; large or behavior-sensitive batches can still usehelp wanted.
Completion criteria
- The first batch and PR #9497 are reviewed against the merged configuration on
main. - The five new implementation workstreams are completed with justified exceptions and required tests/CI.
- The sixth workstream classifies all remaining deferred rules with concrete evidence, maintainer decisions and current config comments.
- Final lint/type/build and appropriate test checks are verified on the integrated branch, not inferred from individual PRs.
- The overall outcome is verified: useful rules are enabled, exceptions are intentional and explained, and no untracked required follow-up work remains.
Do not close this epic merely because the native sub-issue percentage reaches 100%.
Related: #8051.
- Dominant language
- PHP
- Stars
- 844
- Forks
- 176
- Avg merge
- 14h 3m
- Merged PRs (30d)
- 344
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from LibreSign/libresign
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
OpenSSL engine: leaf certificates get O=Internet Widgits Pty Ltd, ST=Some-State from system openssl.cnfPossibly taken @vitormattos claimed this 5 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LibreSign/libresign#9366 · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
LibreSign/libresign#9007 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LibreSign/libresign#8284 · 5 comments ·
Maintainers usually reply within 1 day
-
frontend javascript technical debt
Difficulty 5/5 Over a week Newbie friendliness 8/100
Maintainers usually reply within 1 day
All issues in LibreSign/libresign
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Automattic/blocks-engine#6318 ·
Maintainers usually reply within 1 day
-
[remove-resource] Delete Open Course Hub, Open Multicourse Hub, and Learn2 with GitSync skeletonsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
35-feedback
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day