Harden Unified Search results, navigation and thumbnails
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 15/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Active
- Tech stack
- php, typescript
- Domain
- authorization, backend, search
Research direction
Start with formatResult() in lib/Search/FileSearchProvider.php, then read the thumbnail path in getThumbnailByFileId() in lib/Controller/FileController.php and the routes in src/router/router.ts. The issue asks for a documented result contract and per-role navigation, which needs a design decision before code. Done means the acceptance criteria hold, with tests for owner, signer, observer and unrelated-user cases.
Written by the indexing model from the issue text.
Description
Goal
Return lightweight, privacy-preserving Unified Search entries that navigate correctly for the authenticated participant.
Starting points
lib/Search/FileSearchProvider.php::formatResult()lib/Controller/PageController.phplib/Controller/FileController.php::getThumbnailByFileId()src/router/router.ts
Requirements
- Define the minimal result fields required by Nextcloud Unified Search.
- Distinguish LibreSign document IDs, Nextcloud node IDs and UUIDs.
- Avoid exposing the owner's internal filesystem path to unrelated participant accounts.
- Build navigation URLs appropriate to document type, participant role and signing state.
- Preserve existing document authorization at destination endpoints.
- Reuse the existing
mimeFallbackcapability for lightweight PDF search thumbnails. - Handle envelopes and documents without an accessible Nextcloud node.
- Avoid returning sensitive information through result attributes or error messages.
- Preserve existing full-preview behavior outside search.
Acceptance criteria
- Authorized owners, signers and observers receive appropriate metadata.
- Result URLs open the intended authorized workflow.
- Unrelated users cannot obtain private metadata through search or thumbnail requests.
- IDs and attributes follow a documented, unambiguous contract.
- Search thumbnail requests avoid unnecessary PDF preview generation.
- Missing files and unavailable thumbnails degrade safely.
- Unit and integration tests cover positive and negative cases.
- Existing validation and signing behavior remains unchanged.
Implementation guidance
Prefer small changes to the existing provider and controllers.
A dedicated search-result projection is acceptable if it reduces unnecessary entity hydration or filesystem access. Do not introduce a new presentation framework without evidence of need.
Use the authorization behavior established by the participant-visibility work.
- Dominant language
- PHP
- Stars
- 844
- Forks
- 176
- Avg merge
- 14h 3m
- Merged PRs (30d)
- 344
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from LibreSign/libresign
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
OpenSSL engine: leaf certificates get O=Internet Widgits Pty Ltd, ST=Some-State from system openssl.cnfPossibly taken @vitormattos claimed this 5 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LibreSign/libresign#9366 · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
LibreSign/libresign#9007 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LibreSign/libresign#8284 · 5 comments ·
Maintainers usually reply within 1 day
-
frontend javascript technical debt
Difficulty 5/5 Over a week Newbie friendliness 8/100
Maintainers usually reply within 1 day
All issues in LibreSign/libresign
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Automattic/blocks-engine#6318 ·
Maintainers usually reply within 1 day
-
[remove-resource] Delete Open Course Hub, Open Multicourse Hub, and Learn2 with GitSync skeletonsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
35-feedback
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day