No input-size guard in scanNotes/loadTopics (unlike the TOC reader)
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #415 by @Kuldeep2822k — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- nodejs, typescript
- Domain
- cli, performance
Research direction
The unbounded reads are at src/storage/scanner.ts:157 (scanNotes) and loader.ts:229 (loadTopics), both calling readFileSync on the whole file. Start with the size cap in toc.ts, where TOC_MAX_SOURCE_BYTES is defined and checked before reading, and check how that skip is reported. Done means both readers stat the file first, skip anything over the same limit, and emit a diagnostic instead of loading it; a test with an oversized fixture should show the skip.
Written by the indexing model from the issue text.
Description
Location: src/storage/scanner.ts:157; loader.ts:229
Unbounded readFileSync + whole-buffer parse; toc.ts caps at 512 KiB (TOC_MAX_SOURCE_BYTES, #263) but scanner/loader do not. A multi-MB file (export/pasted log) in the vault is fully loaded and line-scanned on every scan.
Fix: Stat-first size ceiling mirroring TOC_MAX_SOURCE_BYTES; skip-with-diagnostic.
From the 2026-10-10 codebase audit sweep (CODEBASE_AUDIT.md).
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 0
- Avg merge
- 21h 20m
- Merged PRs (30d)
- 176
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Kuldeep2822k/cli
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Kuldeep2822k/cli#550 ·
Maintainers usually reply within 1 day
-
bug core priority: medium
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Kuldeep2822k/cli#547 ·
Maintainers usually reply within 1 day
-
bug cli priority: medium
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Kuldeep2822k/cli#546 ·
Maintainers usually reply within 1 day
-
bug priority: medium security
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Kuldeep2822k/cli#544 ·
Maintainers usually reply within 1 day
-
bug priority: medium storage
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Kuldeep2822k/cli#543 ·
Maintainers usually reply within 1 day
All issues in Kuldeep2822k/cli
Similar issues
-
Native Web
Difficulty 1/5 Under an hour Newbie friendliness 80/100
digitalfabrik/integreat-app#4517 ·
Maintainers usually reply within 2 days
-
TLS guide repeats certs/ in the certificate directoryPossibly taken @maheshrijal claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
prometheus/docs#3156 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
medusajs/dtc-starter#90 ·
Maintainers usually reply within 1 day
-
usability
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
inmanta/web-console#7632 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
zaidmukaddam/scira#261 ·