Follow-up on #2518 for the failing RecursiveShapeIterator test

Open
#2,534 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
28/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Active
Tech stack
cpp
Domain
backend

Research direction

The failing test is dbRecursiveShapeIteratorTest:10, so start by building the KLayout test suite and running that case to see the actual failure. Read the patch for the original ticket in #2518 first, since this issue says it does not cover this problem. The issue does not describe the failure itself, so confirm the cause in the recursive shape iterator code before changing anything. Done means the test passes without breaking the other iterator tests.

Written by the indexing model from the issue text.

Description

The patch for the original ticket does not cover this particular problem with the dbRecursiveShapeIteratorTest:10 test. Hence this follow-up on https://github.com/KLayout/klayout/issues/2518.

Dominant language
C++
Stars
1.2k
Forks
305
Avg merge
3d 2h
Merged PRs (30d)
11

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from KLayout/klayout

All issues in KLayout/klayout

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.