"Change all" function does not work as expected

Open
  • Is something wrong?
#2,249 4 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
desktop

Research direction

Reproduce the two workflows in KLayout 0.30.4 using the issue's array-instance steps, then compare how the Properties window handles rotation from the Instances pane versus a single instance with “Change all” checked. Start by tracing the property handling for those controls; the issue names no source files or tests. Done means both workflows update all instances in the same way.

Written by the indexing model from the issue text.

Description

Hi,

Reproduction steps:

  1. Create new layout and draw some kind of shape.
  2. Make cell drawn by step 1 shape.
  3. Make array instances. ex)3x2
  4. Select multiple instances and open property.
  5. 5-1: Select "Instances" from the left pane and change the Rotation value.
    5-2: With a single instance selected, check the "Change all" checkbox. Then modify the Rotation value.
  6. Click OK to close the Properties window.
Image

What happens:
In case 5-1, the changes will be reflected in all instances.
However, in case 5-2, the changes will only be reflected in the single instance that was selected before checking “Change all”.

Expected behavior:
Both 5-1 and 5-2 should perform the same operation.

Or, is my usage or understanding incorrect?

Versions:
App: Klayout 0.30.4
OS: Windows 11

Dominant language
C++
Stars
1.2k
Forks
305
Avg merge
3d 2h
Merged PRs (30d)
11

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from KLayout/klayout

All issues in KLayout/klayout

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.