strm2oas should read --lefdef-lefs and --lefdef-lef-layouts only once

Open
  • Is something wrong?
#2,121 3 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp
Domain
cli

Research direction

Start by running the provided command from klayout/testdata/lefdef/multi_def and compare the output for each DEF file. Investigate how strm2oas handles --lefdef-lefs and --lefdef-lef-layouts during that run. Done means each listed LEF is read only once rather than being reread for every DEF file.

Written by the indexing model from the issue text.

Description

https://github.com/KLayout/klayout/issues/2041 was closed for 0.30.2, reopening

changing --lefdef-macro-resolution-mode=2 to =1 is also a good testcase for the open https://github.com/KLayout/klayout/issues/1506

cd klayout/testdata/lefdef/multi_def

strm2oas --version
0.30.3 r681d7eeb4

strm2oas \
        --debug-level=11 \
        --lefdef-macro-resolution-mode=2 \
        \
        --lefdef-no-implicit-lef \
        --lefdef-map=layers.map \
        --lefdef-lefs=\
        tech.lef,\
        comp_a.lef,\
        comp_b.lef,\
        comp_c.lef \
        \
        comp_a.def,\
        comp_b.def,\
        comp_c.def,\
        main.def \
        \
        strm2oas.oas

Total: started
Reading LEF/DEF map file klayout/testdata/lefdef/multi_def/layers.map
Reading tech.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/tech.lef
Reading comp_a.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_a.lef
Reading comp_b.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_b.lef
Reading comp_c.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_c.lef
Reading comp_a.def
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_a.def
Reading LEF/DEF map file klayout/testdata/lefdef/multi_def/layers.map
Reading tech.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/tech.lef
Reading comp_a.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_a.lef
Reading comp_b.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_b.lef
Reading comp_c.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_c.lef
Reading comp_b.def
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_b.def
Reading LEF/DEF map file klayout/testdata/lefdef/multi_def/layers.map
Reading tech.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/tech.lef
Reading comp_a.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_a.lef
Reading comp_b.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_b.lef
Reading comp_c.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_c.lef
Reading comp_c.def
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_c.def
Reading LEF/DEF map file klayout/testdata/lefdef/multi_def/layers.map
Reading tech.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/tech.lef
Reading comp_a.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_a.lef
Reading comp_b.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_b.lef
Reading comp_c.lef
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/comp_c.lef
Reading main.def
Reading LEF/DEF file klayout/testdata/lefdef/multi_def/main.def
Total: 0 (user) 0 (sys) 0.002995738 (wall) 47.11M (mem)
Dominant language
C++
Stars
1.2k
Forks
305
Avg merge
3d 2h
Merged PRs (30d)
11

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from KLayout/klayout

All issues in KLayout/klayout

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.