Rename RelativePath.relative_to()?
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- python
- Domain
- operating-systems
Research direction
Start with filesystems/_path.py lines 95-101 and compare the method's behavior and docstring with pathlib.PurePath.relative_to(). Also locate Path.cwd() and review how its path parameter is used. Done means the naming and default-parameter proposal are applied consistently without breaking the existing filesystem API.
Written by the indexing model from the issue text.
Description
This just doesn't read properly to me. I expect relative_to() to take an absolute path and create a relative one. Even the docstring uses 'resolve' instead. Perhaps my reading of it is tainted by pathlib but I think it's separately reasonable.
https://docs.python.org/3.7/library/pathlib.html#pathlib.PurePath.relative_to
I'll propose resolve(). I'd also provide a default for the path parameter of Path.cwd().
- Dominant language
- Python
- Stars
- 2
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Julian/Filesystems
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Julian/Filesystems#51 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Julian/Filesystems#50 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
Julian/Filesystems#45 ·
-
fs.chownOpen
Difficulty 5/5 Over a week Newbie friendliness 15/100
Julian/Filesystems#44 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
Julian/Filesystems#43 ·
All issues in Julian/Filesystems
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lugassawan/swe-workbench#799 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
vllm-project/vllm#61131 ·
Maintainers usually reply within 1 day
-
Non-string form field names raise AttributeError when files are attachedPossibly taken @nightcityblade claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
kubernetes-client/python#2735 ·
Maintainers usually reply within 1 day
-
desktop help wanted test
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day