returning `Connection`

Open
  • Is something wrong?
#56 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
julia
Domain
cli

Research direction

Start by locating the definitions and callers of remote_repl and connect_repl, then inspect how _repl_client_connection and the ReplMaker prompt are used. Decide the consistent return contract and verify that callers can retain and close a Connection, including the multiple-connection case.

Written by the indexing model from the issue text.

Description

Currently remote_repl returns a connection and writes to the global _repl_client_connection.

And connect_repl doesn't return a connection but also writes to the global _repl_client_connection.

I find this behavior inconsistent. Is it necessary that connect_repl returns the ReplMaker prompt ?
In any case, I think it would be nice to also return the Connection.
This way the client can always have a way of closing the connection. (without having to access the global _repl_client_connection)
Aside from that, this could also enable handling multiple connections.

Dominant language
Julia
Stars
148
Forks
17
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from JuliaWeb/RemoteREPL.jl

All issues in JuliaWeb/RemoteREPL.jl

Similar issues

More Julia issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.