savehtml adds an extra html tag

Open
  • Is something wrong?
#37 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
html, julia
Domain
web-dev

Research direction

Start by running the provided Julia reproduction with Hyperscript and inspect the savehtml entry point. The fix is done when the written file matches the printed document with only the doctype added, without a duplicated html wrapper.

Written by the indexing model from the issue text.

Description

Problem

When calling savehtml() it adds an extra layer of <html></html> on top of what is already there.

To reproduce:

julia> using Hyperscript

julia> doc1 = m("html", m("h1", "Hello"))
<html><h1>Hello</h1></html>

julia> savehtml("/tmp/doc1.html", doc1) ## html html
56

shell> cat /tmp/doc1.html
<!doctype html>
<html><html><h1>Hello</h1></html></html>

Expected behavior

I would expect the content of the file written by savehtml to be the same as printed, except for an added doctype.

Versions

(@v1.6) pkg> status Hyperscript
      Status `~/.julia/environments/v1.6/Project.toml`
  [47d2ed2b] Hyperscript v0.0.4

julia> versioninfo()
Julia Version 1.6.1
Commit 6aaedecc44 (2021-04-23 05:59 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, skylake)
Dominant language
Julia
Stars
105
Forks
12
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from JuliaWeb/Hyperscript.jl

All issues in JuliaWeb/Hyperscript.jl

Similar issues

More Julia issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.