`size`, `length`, `ndims` for `Plan` inconsistent with Base usage
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start by reviewing the existing Plan definitions and the API concerns in this issue and linked FFTW.jl issue #159, focusing on size, length, and ndims. A complete contribution would require a settled decision about their semantics, followed by the corresponding implementation and verification that Plan behavior is consistent with that decision.
Written by the indexing model from the issue text.
Description
Ref. https://github.com/JuliaMath/FFTW.jl/issues/159
While it is certainly useful to be able to query a Plan for the size of the input data it expects, using size for this seems wrong. It should give the dimensions of the Plan itself, whatever that might be. As noted in https://github.com/JuliaMath/FFTW.jl/issues/159, a Plan for 1d input of length n could be considered equivalent to a matrix with size (n, n), but size would just return n.
So we might consider renaming size as used here, and maybe ndims along with it if deemed necessary to have it, noting the trivial definition length(size(p)). I don't see how length is useful, so that could maybe just be deleted.
I'm skeptical about defining size, length, ndims in a way (more) consistent with Base, unless we make Plans iterable (and maybe even indexable), where I don't see much benefit.
- Dominant language
- Julia
- Stars
- 135
- Forks
- 40
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from JuliaMath/AbstractFFTs.jl
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
JuliaMath/AbstractFFTs.jl#159 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
JuliaMath/AbstractFFTs.jl#147 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
JuliaMath/AbstractFFTs.jl#135 ·
-
Difficulty 5/5 Over a week Newbie friendliness 28/100
JuliaMath/AbstractFFTs.jl#125 · 2 reactions ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
JuliaMath/AbstractFFTs.jl#122 · 3 comments ·
All issues in JuliaMath/AbstractFFTs.jl
Similar issues
-
io
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
JuliaGPU/GPUArrays.jl#837 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
bmad-sim/BeamTracking.jl#382 ·
Maintainers usually reply within 1 day