type-flexible FFTs?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- julia
- Domain
- backend-api-design
Research direction
Read src/definitions.jl at lines 20–22 and the linked FourierTransforms.jl issue to understand the current type restrictions and the proposed pure-Julia behavior. Determine whether the AbstractFFTs definitions can support AbstractFloat element types without breaking existing FFT implementations; done means an agreed API change with behavior validated for the relevant types.
Written by the indexing model from the issue text.
Description
I've raised this issue https://github.com/JuliaComputing/FourierTransforms.jl/issues/8#issue-495818536, which is about https://github.com/JuliaMath/AbstractFFTs.jl/blob/66695a72b2a29a059a9bf5fae51a3107172f146d/src/definitions.jl#L20-L22
In theory, FourierTransforms.jl should allow for a type-flexible FFT, i.e. fft(::Array{T,1}) where {T<:AbstractFloat}, but currently it doesn't. Would it be possible to change these lines thanks to the pure-Julia FourierTransforms.jl, which is not limited to Float32/Float64 (as for example FFTW is)?
- Dominant language
- Julia
- Stars
- 135
- Forks
- 40
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from JuliaMath/AbstractFFTs.jl
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
JuliaMath/AbstractFFTs.jl#159 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
JuliaMath/AbstractFFTs.jl#147 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
JuliaMath/AbstractFFTs.jl#135 ·
-
Difficulty 5/5 Over a week Newbie friendliness 28/100
JuliaMath/AbstractFFTs.jl#125 · 2 reactions ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
JuliaMath/AbstractFFTs.jl#122 · 3 comments ·
All issues in JuliaMath/AbstractFFTs.jl
Similar issues
-
TSDAE's docstring implies a theta argument it does not takePossibly taken @singhharsh1708 claimed this today. Opendocumentation
Difficulty 1/5 Under an hour Newbie friendliness 74/100
SciML/PETScDiffEq.jl#282 ·
Maintainers usually reply within 1 day
-
enhancement good first issue help wanted
Difficulty 2/5 Half a day Newbie friendliness 82/100
-
SavedSubsystem with an integer save_idxs maps the index the wrong way roundPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
SciML/SciMLBase.jl#1643 ·
Maintainers usually reply within 2 days
-
authority-vechtstromen ready-for-agent
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Deltares/Ribasim-NL#890 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 1 day