Inverse plans
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 30/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- julia
- Domain
- backend-api-design
Research direction
Start by reviewing AbstractFFT's plan_inv and inv behavior, then compare the existing ScaledPlan API. Determine how inverse-plan computation and caching should avoid mutating the supplied plan, and consider the proposed wrapper with p and pinv fields. Done means the API design is settled and its effects on immutable, strictly typed plans are evaluated.
Written by the indexing model from the issue text.
Description
To me it seems a bit unintuitive that AbstractFFT assumes that plans have a field pinv which is populated when calling inv. When computing the inverse via inv I don't expect the provided element to be mutated.
I would suggest to replace plan_inv with inv such that calling inv returns the inverse plan but does not mutate the given plan. Similar to ScaledPlan a wrapper type could be provided that contains a plan and its inverse (e.g. as fields p and pinv). In my opinion, this would make computing and caching of inverse plans more transparent. Additionally, it would allow plans to be immutable and strictly typed (and hence maybe improve performance?).
What do you think?
- Dominant language
- Julia
- Stars
- 135
- Forks
- 40
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from JuliaMath/AbstractFFTs.jl
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
JuliaMath/AbstractFFTs.jl#159 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
JuliaMath/AbstractFFTs.jl#147 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
JuliaMath/AbstractFFTs.jl#135 ·
-
Difficulty 5/5 Over a week Newbie friendliness 28/100
JuliaMath/AbstractFFTs.jl#125 · 2 reactions ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
JuliaMath/AbstractFFTs.jl#122 · 3 comments ·
All issues in JuliaMath/AbstractFFTs.jl
Similar issues
-
TSDAE's docstring implies a theta argument it does not takePossibly taken @singhharsh1708 claimed this today. Opendocumentation
Difficulty 1/5 Under an hour Newbie friendliness 74/100
SciML/PETScDiffEq.jl#282 ·
Maintainers usually reply within 1 day
-
enhancement good first issue help wanted
Difficulty 2/5 Half a day Newbie friendliness 82/100
-
SavedSubsystem with an integer save_idxs maps the index the wrong way roundPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
SciML/SciMLBase.jl#1643 ·
Maintainers usually reply within 2 days
-
authority-vechtstromen ready-for-agent
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Deltares/Ribasim-NL#890 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 1 day