Squash implementation missing

Open
  • Is something wrong?
#497 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
julia
Domain
data

Research direction

Start in test/core.jl around line 112, where the deprecation warning is shown, and inspect the existing squash specializations and graph types used by the tests. Determine which types still fall back to squash(::AbstractGraph), add the missing specializations, and run the relevant core tests to confirm the warning is gone.

Written by the indexing model from the issue text.

Description

Some squash implementations are missing:

 Warning: squash(::AbstractGraph) is deprecated in favor of methods that specialize on the graph type.
│   caller = macro expansion at core.jl:112 [inlined]
└ @ Core ~/work/Graphs.jl/Graphs.jl/test/core.jl:112

Just needs the specialisations function checking for which types are missing. Happy to take.

Dominant language
Julia
Stars
540
Forks
131
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from JuliaGraphs/Graphs.jl

All issues in JuliaGraphs/Graphs.jl

Similar issues

More Julia issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.