Possible thread safety issue with `active_devices`

Open
  • Is something wrong?
#40 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
julia
Domain
tooling

Research direction

Start by locating every read and write of active_devices in the repository and checking how threaded use is exercised. Reproduce the reported concurrent access if possible, then add coverage for the concurrent behavior; done means reading active_devices while another thread adds a key no longer causes undefined behavior.

Written by the indexing model from the issue text.

Description

The use of active_devices might not be thread safe if this library is used in more than one thread. Putting a new key in active_devices could cause it to be reallocated in one thread while another thread is reading which might cause undefined behaviour.

Dominant language
Julia
Stars
69
Forks
24
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from JuliaGraphs/GraphViz.jl

All issues in JuliaGraphs/GraphViz.jl

Similar issues

More Julia issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.