Replace withsomezeros_rewrap with ProjectTo

Open
  • Is something wrong?
#815 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
julia
Domain
backend

Research direction

Start with norm.jl and locate the withsomezeros helper and its other uses. Compare its behavior with ProjectTo, then determine whether the relevant uses can be replaced while preserving Triangular, Diagonal, and related matrix types; done means the replacements work without changing those results.

Written by the indexing model from the issue text.

Description

refactoring

code in a few places e.g. norm.jl uses a helper function called withsomezeros that handles making Triangular and Diagonal (etc) matrixes back into the correct types.
This seems very similar to ProjectTo and we could likely replace it with that

Dominant language
Julia
Stars
479
Forks
100
Avg merge
1d 4h
Merged PRs (30d)
14

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from JuliaDiff/ChainRules.jl

All issues in JuliaDiff/ChainRules.jl

Similar issues

More Julia issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.