missing test coverage: `setindex!` should return the collection (not the element)
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 62/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Domain
- testing
Research direction
Start with the merged PR #829 to find which setindex! method it changed and what it now returns. Then look for the existing test file covering that collection and run the test suite to confirm the current behaviour. Done when a new test asserts that setindex! returns the collection and the suite passes.
Written by the indexing model from the issue text.
Description
PR #829 fixed a bug. Merged without adding any test.
- Dominant language
- Julia
- Stars
- 747
- Forks
- 261
- Avg merge
- 12d 6h
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from JuliaCollections/DataStructures.jl
-
append!(l1::MutableLinkedList, l2::MutableLinkedList) fails for empty l2Possibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
JuliaCollections/DataStructures.jl#997 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
-
several `mutable struct` type definitions do not require mutability, review and adjustPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
a slighly uncanny `UndefRefError` with default-empty SortedSetPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 3/5 1-2 days Newbie friendliness 52/100
JuliaCollections/DataStructures.jl#969 · 6 comments ·
All issues in JuliaCollections/DataStructures.jl
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
oscar-system/GAP.jl#1455 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
JuliaAI/MLJTransforms.jl#85 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
SciML/OrdinaryDiffEq.jl#4875 ·
Maintainers usually reply within 4 days
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
SciML/NonlinearSolve.jl#1372 ·
Maintainers usually reply within 1 day