`MLJBase.scitype` conflict with `ScientificTypes.scitype`
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- julia
- Domain
- machine-learning
Research direction
Start by tracing the scitype exports in MLJBase and ScientificTypes and the light/full interface in MLJModelInterface. Review how weak dependencies and conditional code loading could affect the existing interface and precompilation behavior. Done means an agreed resolution with its compatibility and breakage implications documented.
Written by the indexing model from the issue text.
Description
Currently MLJBase and ScientificTypes both export scitype, which creates a name clash. This has not appeared to have caused many problems because MLJBase, which has ScientificTypes as a dependency, re-exports all the other names that ScientificTypes exports, so there is generally no need for the MLJBase user (or MLJ user) to also do using ScientificTypes. But this state of affairs is confusing, and I hit my head against it recently. The issue is that MLJBase.scitype is not just a re-export of ScientificTypes.scitype (even though the first does in fact call the latter). This has to do with the "light/full interface" switch we created to ensure MLJModelInterface could be ultra-light weight, but still refer to names in packages that aren't dependencies ... a long story I'll not go into here, except to say this "hack" has another drawback: the global variable which flags whether we are using the "light" interface (MLJBase is not loaded) or "full" interface (MLJBase is loaded) kills the benefit of adding a precompilation load to MLJ (there was an issue about this, but I cannot find it just now).
What to do about this? Probably any solution is going to create significant breakages, so probably we live with this until such time as we eliminate the "hack" referred to above, which is probably rendered unnecessary with the advent of weak dependencies and conditional code loading. But I wanted to flag this issue.
- Dominant language
- Julia
- Stars
- 164
- Forks
- 46
- Avg merge
- 23h 18m
- Merged PRs (30d)
- 3
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from JuliaAI/MLJBase.jl
-
Evaluate is using `external_aggregation_mode` of a measure to perform "internal" aggregationPossibly taken @ablaom claimed this 18 days ago. Open
JuliaAI/MLJBase.jl#1088 · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
JuliaAI/MLJBase.jl#1085 ·
Maintainers usually reply within 1 day
-
Have `unpack` support `String` names for the columnsPossibly taken @OkonSamuel claimed this 297 days ago. Open
JuliaAI/MLJBase.jl#1043 · 3 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
next breaking release
Difficulty 3/5 1-2 days Newbie friendliness 35/100
JuliaAI/MLJBase.jl#1021 ·
Maintainers usually reply within 1 day
-
Weights in pipelinesOpen
Difficulty 4/5 3-5 days Newbie friendliness 42/100
JuliaAI/MLJBase.jl#1005 · 2 comments ·
Maintainers usually reply within 1 day
All issues in JuliaAI/MLJBase.jl
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Sienna-Platform/PowerSimulations.jl#1737 ·
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
FluxML/Optimisers.jl#254 ·
-
Minor: floodplain warning percentage, scalar output error message and a never-true identity checkOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
JuliaAI/MLJTransforms.jl#101 ·
Maintainers usually reply within 1 day
-
@contents blocks fail to render on Julia 1.14Possibly taken @sbfnk claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LuxDL/DocumenterVitepress.jl#410 ·