Rename internal methods from `By` to `From`.

Open Beginner friendly
  • Is something wrong?
#1,558 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
php
Domain
backend

Research direction

Search the codebase for the three listed method names and read their definitions and call sites. Rename them from By to From consistently, then run the relevant tests to verify the updated methods and usages work.

Written by the indexing model from the issue text.

Description

major-release

Rename methods from By to From.

MediaTypeEncoder::encoderByMediaType() -> encoderFromMediaType()
AbstractDecoder::mediaTypeByBinary() -> mediaTypeFromBinary()
AbstractDecoder::mediaTypeByFilePath() -> mediaTypeFromFilePath()

Dominant language
PHP
Stars
14.4k
Forks
1.5k
Avg merge
19h 22m
Merged PRs (30d)
14

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Intervention/image

All issues in Intervention/image

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.