TxSubmission2 decodes unbounded duplicate txs in MsgReplyTxs

Open
  • Is something wrong?
#5,472 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 4 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
43/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
haskell
Domain
networking

Research direction

Start with ouroboros-network/protocols/lib/Ouroboros/Network/Protocol/TxSubmission2/Codec.hs at the MsgReplyTxs decoder, then read the V1 and V2 inbound deduplication sites linked in the issue. Trace how the reply list is decoded before deduplication and consider how duplicate copies can be bounded. Done when decoding no longer permits an unbounded number of duplicate transactions; the issue names no tests to run.

Written by the indexing model from the issue text.

Description

MsgReplyTxs is decoded as an unbounded list and only deduped afterwards (V1, V2), so a peer can send many copies of one tx.

Dominant language
Haskell
Stars
297
Forks
105
Avg merge
3d 14h
Merged PRs (30d)
10

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from IntersectMBO/ouroboros-network

All issues in IntersectMBO/ouroboros-network

Similar issues

More Haskell issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.