Better tear down on critical failure

Open
  • Is something wrong?
#102 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
52/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Quiet
Tech stack
haskell
Domain
security

Research direction

Read kes-agent/src/Cardano/KESAgent/Processes/ControlClient.hs around line 210 and trace the critical-failure teardown path. Determine why the current error call is used and what behavior the issue expects instead; done when that path no longer uses the inappropriate error call and the relevant tests pass.

Written by the indexing model from the issue text.

Description

https://github.com/f-f/kes-agent/blob/c0d24ab8bf8f9f736aed3c7028534355fb89ecaa/kes-agent/src/Cardano/KESAgent/Processes/ControlClient.hs#L210

This should probably not be an error call

Dominant language
Haskell
Stars
2
Forks
13
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from IntersectMBO/kes-agent

All issues in IntersectMBO/kes-agent

Similar issues

More Haskell issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.