[MAINTENANCE] - Remove usages of `SafeHash`
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 30/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Quiet
- Tech stack
- haskell
- Domain
- blockchain, cli
Research direction
Search the repository for all usages and unsafe creations of SafeHash, then trace each use to determine whether its source can be tracked. Review the affected Cardano CLI and API interfaces first; done means usages use unverified Hash except where conversion at a lower-level interface is unavoidable.
Written by the indexing model from the issue text.
Description
What
Replace all usages of SafeHash with unverified Hash unless in cases where it is possible to track the source of the hash. If somewhere this is unavoidable, wait till the last second before unsafely converting to SafeHash.
Why
SafeHash is meant to encode that the hash has a pre-image, but this is not enforceable most of the time in practice, since both cardano-cli and cardano-api are often provided with the hash only, not with the pre-image.
Acceptance Criteria
- There are no unsafe creations of
SafeHashwith the possible exception of just before interfaces with modules down the stack if unavoidable.
- Dominant language
- Haskell
- Stars
- 72
- Forks
- 25
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 8
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from IntersectMBO/cardano-cli
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
IntersectMBO/cardano-cli#1306 · 2 comments ·
Maintainers usually reply within 1 day
-
Ensure Plutus V4 scripts can be deserialised by cardano-cliPossibly taken @carbolymer claimed this 17 days ago. Openenhancement
IntersectMBO/cardano-cli#1448 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
Upstream non-Leios commits from the Leios integration branch to masterMay be free again @palas claimed this 58 days ago, and no pull request is open. Openrefactor
IntersectMBO/cardano-cli#1414 · 1 assignee ·
Maintainers usually reply within 1 day
-
Add `transaction validate` command (online phase 1 + phase 2)Possibly taken @palas claimed this 144 days ago. Openenhancement epic
IntersectMBO/cardano-cli#1380 · 4 comments · 1 reaction · 1 assignee ·
Maintainers usually reply within 1 day
-
Investigate incorporating cquisitor-style local tx validation (phase 1 + phase 2) into cardano-cliMay be free again @palas claimed this 165 days ago, and no pull request is open. Open
IntersectMBO/cardano-cli#1367 · 6 comments · 1 assignee ·
Maintainers usually reply within 1 day
All issues in IntersectMBO/cardano-cli
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
halogenandtoast/ArkhamHorror#5825 · 1 comment ·
-
docs: install-manifest download links use main instead of master (404)Possibly taken @ChinmayaBisoi claimed this 1 day ago. Open
Difficulty 2/5 Under an hour Newbie friendliness 78/100
hasura/graphql-engine#10884 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
AccelerateHS/accelerate#583 · 2 comments ·
-
component: hls-refactor-plugin status: needs triage type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
haskell/haskell-language-server#5111 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
alunduil/network-arbitrary#193 ·
Maintainers usually reply within 1 day