Properly download any region init script for offline Onyxia instances

Open
  • Is something wrong?
#407 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 3 days

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Active
Tech stack
shell
Domain
devops, security

Research direction

Open base/scripts/onyxia-init.sh at lines 16-23 and review why the --insecure flag remains after Onyxia issue 56 was solved. Check that issue and the linked download flow first, then test downloading an init script for each region in an offline instance. Done means region scripts download successfully without --insecure.

Written by the indexing model from the issue text.

Description

We sould work on removing the --insecure flag. The comment says that it depended on this issue, which was solved. How should we fix this ? @fcomte @phlg

https://github.com/InseeFrLab/images-datascience/blob/9aead1ee3098b2f1669b50f12f63d6315b78bf4e/base/scripts/onyxia-init.sh#L16-L23

Dominant language
Shell
Stars
43
Forks
37
Avg merge
4d 12h
Merged PRs (30d)
10

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from InseeFrLab/images-datascience

All issues in InseeFrLab/images-datascience

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.