Declare the real Node.js requirement for loading the packages (engines vs require())
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- node.js, typescript
- Domain
- developer-experience
Research direction
Read the package engines declarations alongside the Node.js version results listed in the issue and the related discussions in #1200, #1201, #882, and #884. Decide the supported Node.js floor for the next major release, then align engines with that decision; done means the declared floor matches the chosen support policy for both ESM imports and require().
Written by the indexing model from the issue text.
Description
Summary
All packages declare "node": ">=18.12", but they are ESM only, and require() of them only works on Node.js 20.19+ and 22.12+.
While reviewing #1201 I ran require() on the 14 entry points with real Node binaries:
| Node | require() |
|---|---|
| 18.12.1, 18.20.8 | fails with ERR_REQUIRE_ESM |
| 20.12.2, 20.18.0 | fails with ERR_REQUIRE_ESM |
| 20.19.5 | OK |
| 22.11.0 | fails with ERR_REQUIRE_ESM |
| 22.13.1, 22.17.1 | OK |
ESM import works on 18.12.1. #1201 documents the require() requirement in the CHANGELOG and docs, and leaves engines unchanged because raising it would break ESM users who work today.
Proposal
Decide the supported Node.js floor for the next major release, and align engines with it. Earlier issues on the same topic: #882 and #884 (closed), which asked for >=22.11.0.
Related: #1200, #1201.
- Dominant language
- TypeScript
- Stars
- 276
- Forks
- 26
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 47
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from InditexTech/weavejs
-
Server-side render fails with "requestAnimationFrame is not defined" when the room has a video nodePossibly taken @jesusmpc claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
InditexTech/weavejs#1294 ·
Maintainers usually reply within 1 day
-
internal
Difficulty 4/5 3-5 days Newbie friendliness 35/100
InditexTech/weavejs#1258 ·
Maintainers usually reply within 1 day
-
Generated create-weave-*-app projects do not install, build or run without manual fixesPossibly taken @txnioh claimed this 9 days ago. Openbug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
InditexTech/weavejs#1257 ·
Maintainers usually reply within 1 day
-
Add sticky note canvas primitive and interactive placement toolPossibly taken @jmcaamanog claimed this 21 days ago. Openenhancement
Difficulty 4/5 3-5 days Newbie friendliness 58/100
InditexTech/weavejs#1232 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 48/100
InditexTech/weavejs#1163 ·
Maintainers usually reply within 1 day
All issues in InditexTech/weavejs
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
jupyterlite/jupyterlite#2111 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
karlhorky/electron-app-patcher#241 ·
Maintainers usually reply within 1 day
-
Tab bar scrolls past its last tab in Firefox until no tabs are visiblePossibly taken @daviwil claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
eclipse-theia/theia#18367 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day