secure_equals raises on a non-string, but BUILTINS.md says non-strings return false
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 67/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- c
- Domain
- documentation, testing
Research direction
Read docs/BUILTINS.md at line 123 and inspect the runtime implementation and existing tests for secure_equals to decide which behavior is intended. Update the documentation or runtime so they agree, add a test pinning the chosen behavior, and run the relevant tests.
Written by the indexing model from the issue text.
Description
docs/BUILTINS.md:123 documents secure_equals as "Non-strings → false". On main (d3ec498d), print of (secure_equals of [null, "abc"]) raises secure_equals: expected two strings.
Raising is arguably the better contract (a null secret is a caller bug, and fail-loud is the house rule), so this is probably a docs fix, not a runtime change. Decide which, then make them agree.
Found while reviewing the #2249 fix: lib/auth.eigs only ever passes strings (_extract_bearer returns "" when the header is missing), so auth is not affected.
Done when
-
docs/BUILTINS.mdand the runtime agree on non-string arguments, with a test pinning the chosen behaviour.
— Claude DevBox
- Dominant language
- C
- Stars
- 3
- Forks
- 7
- Avg merge
- 6h 32m
- Merged PRs (30d)
- 285
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from InauguralSystems/EigenScript
-
good first issue needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 88/100
InauguralSystems/EigenScript#2347 · 1 comment ·
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 82/100
InauguralSystems/EigenScript#2335 · 1 comment ·
Maintainers usually reply within 1 day
-
area:embed kind:bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
InauguralSystems/EigenScript#2311 · 1 comment ·
Maintainers usually reply within 1 day
-
area:gates kind:gate-defect
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
InauguralSystems/EigenScript#2305 · 1 comment ·
Maintainers usually reply within 1 day
-
area:ci bug found-by:duet-audit
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
InauguralSystems/EigenScript#2283 ·
Maintainers usually reply within 1 day
All issues in InauguralSystems/EigenScript
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
FujiNetWIFI/fujinet-config#379 ·
Maintainers usually reply within 1 day
-
Ship /Local/Applications, the Local domain's Applications folderPossibly taken @pkgdemon claimed this today. Openarea:base enhancement
Difficulty 1/5 Under an hour Newbie friendliness 94/100
nextbsd/nextbsd-userland#612 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
zephyrproject-rtos/zephyr#125543 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
colbymchenry/codegraph#3277 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100