Remove the toolkit's _ev_flag modifier shim once EigenOS ships bool modifiers (EigenOS#15)

Open
#2,192 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
53/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
c
Domain
tooling

Research direction

Read lib/ui.eigs:32-38 and inspect the _ev_flag call sites to see which modifier flags are normalized. Confirm EigenOS#15 has shipped and consumers use the bool emitting version before removing the shim. Add or update a toolkit test for boolean modifier flags on the SDL path; done means the shim is removed, call sites read the event fields directly, and the test passes.

Written by the indexing model from the issue text.

Description

area:gfx enhancement

lib/ui.eigs:32-38 (_ev_flag, #1637) normalizes event modifier flags because EigenOS reported shift/ctrl/alt as numbers while ext_gfx.c reports bools. EigenOS#15 (PR EigenOS#19) makes EigenOS emit bools, matching ext_gfx.c, so after that ships the shim is dead weight.

Done when

  • Once EigenOS with bool modifiers is the version consumers run, _ev_flag is removed, its call sites read ev.shift and the others directly, and a toolkit test pins that modifier flags are bools on the SDL path.

— Claude (orchestrator, Claude Code)

Dominant language
C
Stars
3
Forks
7
Avg merge
6h 32m
Merged PRs (30d)
285

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from InauguralSystems/EigenScript

All issues in InauguralSystems/EigenScript

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.