Handling and testing other algorithms

Open
#68 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

This issue has not been assessed yet.

Description

Based on this comment:
https://github.com/Imageomics/cautious-robot/pull/60#discussion_r3537629085

We can add an integration test that covers the support for alternate checksum algorithms.

Currently, we say we can support algorithms supplied by hashlib, but that's not true for those that require a length parameter.

A proposal would be to list the algorithms in hashlib, and then just exclude those specialized algorithms that require a length parameter, and others that have optional length parameters are only supported at the default length.
(As called out in sum-buddy)

And validate that the user input is supported with choices, raising a specific error if an unsupported entry is passed.

Dominant language
Python
Stars
6
Forks
1
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Imageomics/cautious-robot

All issues in Imageomics/cautious-robot

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.