improve table linking
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start by reading the three helpers in utils.R: .sync_tables_sdattrs, .sync_shapes_on_drop, and .sync_tables_on_drop. Compare their behavior with the object-wide .zattrs design draft linked in the issue, then inspect existing tests for table, shape, and label links. Done means the current R implementation is clearer and its link behavior is covered by tests.
Written by the indexing model from the issue text.
Description
- We currently have a few helpers to help keep coherent links between tables & shapes/labels; in utils.R:
.sync_tables_sdattrsupdates table spatialdata_attrs.sync_shapes_on_dropfilters observations in linked shapes.sync_tables_on_dropfilters tables when dropping shapes/labels
- A design draft to keep all links as object-wide .zattrs is here
- Since this could take a while, might be worth to see how we can improve & test more the current R implementation; it is quite in-elegant and confusing...
- Dominant language
- R
- Stars
- 37
- Forks
- 10
- Avg merge
- 22h 46m
- Merged PRs (30d)
- 20
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from HelenaLC/spatialdataR
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
HelenaLC/spatialdataR#252 ·
Maintainers usually reply within 1 day
-
axes order in image/label show methodPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
HelenaLC/spatialdataR#239 · 11 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 Half a day Newbie friendliness 60/100
HelenaLC/spatialdataR#271 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
HelenaLC/spatialdataR#251 · 6 comments · 3 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
HelenaLC/spatialdataR#241 ·
Maintainers usually reply within 1 day
All issues in HelenaLC/spatialdataR
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
HakaiInstitute/hydrocan#35 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
core
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day