Allow customizing handling of out-of-range counts when serializing
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
Research direction
Start with the serialization handling described in this issue and review the behavior referenced in pull request #40. Define the supported options for counts above i64::max_value(), then verify that serialization follows the selected handling instead of always returning an error.
Written by the indexing model from the issue text.
Description
We allow u64 counts, but the serialization format only allows i64::max_value() as the largest count. So, you can end up with an un-serializable histogram.
It would be nice if the user could choose what to do in such a situation. Right now we always error, which means I needed to do things like https://github.com/jonhoo/hdrsample/pull/40/files#diff-c761d465047faa0efb455f492b2f1e07R528 when testing serialization with random counts.
Options that come to mind:
- Error (we've got this one now)
- Squish oversized counts down to i64::max_value()
- ???
- Dominant language
- Rust
- Stars
- 373
- Forks
- 50
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from HdrHistogram/HdrHistogram_rust
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
HdrHistogram/HdrHistogram_rust#128 · 5 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 32/100
HdrHistogram/HdrHistogram_rust#127 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
HdrHistogram/HdrHistogram_rust#120 · 4 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
HdrHistogram/HdrHistogram_rust#119 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
HdrHistogram/HdrHistogram_rust#114 · 3 comments · 1 reaction ·
All issues in HdrHistogram/HdrHistogram_rust
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
linebender/parley#849 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
boxlite-ai/boxlite#1729 ·
Maintainers usually reply within 1 day
-
external
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
langchain-ai/docs#6255 ·
Maintainers usually reply within 1 day
-
P2 testing
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day