Fix analyzer warnings in Benchmarking and Examples projects
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start by running the CI build or analyzer and inspect the listed locations in HdrHistogram.Benchmarking/Program.cs, HdrHistogram.Examples/Program.cs, and LeadingZeroCountBenchmarkBase.cs. Address the CA1852, CA1707, and CA1829 warnings while preserving the intent of the comparative BBarry implementation names, then verify that all 10 warnings are gone.
Written by the indexing model from the issue text.
Description
Summary
The CI build reports 10 analyzer warnings in the HdrHistogram.Benchmarking and HdrHistogram.Examples projects.
These are pre-existing and not introduced by any recent PR.
Warnings
CA1852 — Type can be sealed (×2)
HdrHistogram.Benchmarking/Program.cs#L9HdrHistogram.Examples/Program.cs#L3
CA1707 — Remove underscores from member/type names (×6)
LeadingZeroCountBenchmarkBase.BBarry_imp1()— line 189LeadingZeroCountBenchmarkBase.BBarry_imp2()— line 199LeadingZeroCountBenchmarkBase.BBarry_imp3()— line 209LeadingZeroCountBenchmarkBase.BBarry_imp4()— line 219BBarry32BitIfShiftLookupWith64BitShiftBranch_2— line 46BBarry32BitIfShiftLookupWith64BitShiftBranch_3— line 79
CA1829 — Use Length instead of Count() (×1)
LeadingZeroCountBenchmarkBase.cs#L42
Notes
All warnings are in the benchmarking and examples projects, not the main library.
The underscore names (BBarry_imp*) reference a contributor's implementation variants used for comparative benchmarking — renaming should preserve the intent of identifying the author/variant.
Reference
- Observed in PR #164 build annotations
- Dominant language
- C#
- Stars
- 185
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from HdrHistogram/HdrHistogram.NET
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
HdrHistogram/HdrHistogram.NET#166 ·
-
WriterReaderPhaser.FlipPhase - Task.Yield().GetAwaiter().GetResult() is a Thread Pool Anti-PatternOpenagent enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
HdrHistogram/HdrHistogram.NET#144 ·
-
agent enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
HdrHistogram/HdrHistogram.NET#142 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
HdrHistogram/HdrHistogram.NET#156 ·
-
agent enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
HdrHistogram/HdrHistogram.NET#148 ·
All issues in HdrHistogram/HdrHistogram.NET
Similar issues
-
Bug pulumi/pulumi
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
activescott/lessmsi#306 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
HTML sitemap lists unpublished pagesPossibly taken @KrzysztofPajak claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
grandnode/grandnode2#883 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day