Existing replay suite leaks its fixture directory when Harper setup fails
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 69/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, node.js, typescript
Research direction
Read the after hook in integrationTests/mcp-runtime.test.ts at lines 102–113 and reproduce with a fresh test-install parent and HARPER_INTEGRATION_TEST_INSTALL_SCRIPT pointing to a missing file. Check how the installed @harperfast/integration-testing 0.5.1 teardown handles the partial context after fixture copying. Done means the setup error is preserved, the allocated fixture root is removed, and normal successful teardown still works.
Written by the indexing model from the issue text.
Description
The existing replay/refresh suite leaves its fixture directory behind when Harper setup fails after copying the fixture.
The suite at mcp-runtime.test.ts calls teardownHarper(ctx) in its after hook. At that failure point, @harperfast/integration-testing 0.5.1 has recorded ctx.harper.dataRootDir but has not populated the started context. Teardown passes an undefined hostname to releaseLoopbackAddress and throws before removing the directory.
To reproduce, run that suite with a fresh test-install parent and HARPER_INTEGRATION_TEST_INSTALL_SCRIPT pointing to a missing file. Fixture copying succeeds, startup reports the missing executable, and the allocated directory remains. A direct call to the installed teardown helper with that partial context reproduces the hostname TypeError. The Node test runner can suppress the after-hook error when the before hook has already failed, so the original startup error alone does not demonstrate cleanup.
Expected: retain the original setup error and remove the resources actually allocated, including the recorded fixture root. Normal successful teardown must remain intact. An upstream helper correction that supports partial context would cover existing callers; test-local handling is another option.
This is a pre-existing test cleanup defect, identified during review of #282. That PR fixes cleanup in its newly added native suite; this issue tracks the older replay/refresh suite. No production authentication or session defect is demonstrated.
Observed on current main 6ba1ff4, Node 24.13.1 and integration-testing 0.5.1. No release is committed. No open OAuth epic owns test infrastructure.
Review-Deferral: 4ed730a2cda1c1f9 severity=nit category=reliability
Generated by OpenAI Codex; posted via @hdbjeff.
- Dominant language
- JavaScript
- Stars
- 1
- Forks
- 3
- Avg merge
- 7h 4m
- Merged PRs (30d)
- 24
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from HarperFast/oauth
-
Difficulty 4/5 3-5 days Newbie friendliness 53/100
HarperFast/oauth#284 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 18/100
HarperFast/oauth#280 ·
Maintainers usually reply within 1 day
-
Open-issue triage and roadmap (post-2.9.0)Possibly taken @heskew claimed this 20 days ago. Open
HarperFast/oauth#278 · 1 assignee ·
Maintainers usually reply within 1 day
-
Session docs overstate expiry: no default lifetime, and invalidation clears fields rather than deleting the rowPossibly taken @heskew claimed this 20 days ago. Open
HarperFast/oauth#277 · 1 assignee ·
Maintainers usually reply within 1 day
-
Azure ?appid= form of the shared-alias keys URL isn't recognizedPossibly taken @heskew claimed this 20 days ago. Open
HarperFast/oauth#275 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in HarperFast/oauth
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
rescript-lang/rescript#8996 ·
Maintainers usually reply within 1 day
-
check:passed logos:add
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
fossasia/visdom-dev#69 ·
Maintainers usually reply within 3 days
-
Difficulty 1/5 Under an hour Newbie friendliness 74/100
-
建议写成 1949-Open
Difficulty 1/5 Under an hour Newbie friendliness 62/100
DeanChensj/jiangshan-map#133 ·
Maintainers usually reply within 1 day