Invalid dll-path when there is a '#' in the path

Open
  • Is something wrong?
#107 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
csharp
Domain
backend

Research direction

Start by locating NativeDependencies.GetAssemblyName() and review how it derives the binary search path from Assembly.CodeBase. Reproduce the issue with an assembly path containing '#', then verify that the resolved directory preserves the full path and that native dependency lookup still works.

Written by the indexing model from the issue text.

Description

In NativeDependencies.GetAssemblyName() the binary search path based on this code:

string myPath = new Uri(System.Reflection.Assembly
    .GetExecutingAssembly().CodeBase).AbsolutePath;
myPath = Uri.UnescapeDataString(myPath);
return myPath;

which transforms a path c:\Dir\Sub#Dir\HDF.PInvoke.dll into c:\Dir\Sub.

A fix could look like this:

var myPath = System.Reflection.Assembly.GetExecutingAssembly().Location;
return Path.GetDirectoryName( myPath );

which transforms a path c:\Dir\Sub#Dir\HDF.PInvoke.dll into c:\Dir\Sub#Dir.

Dominant language
C#
Stars
87
Forks
32
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from HDFGroup/HDF.PInvoke

All issues in HDFGroup/HDF.PInvoke

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.