Type hint is selected in node graph view

Open Beginner friendly
#4,311 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
javascript
Domain
frontend

Research direction

Start with frontend/src/components/floating-menus/NodeCatalog.svelte around lines 110-111 and frontend/src/components/widgets/inputs/TextInput.svelte around lines 31-35. Reproduce the node catalogue search after dragging a typed wire, then trace the focus change and text selection behavior. Done means the input still receives focus while the resolved type is not automatically selected, so typing narrows the search normally.

Written by the indexing model from the issue text.

Description

Reproduction

  • Drag a wire from an output with a resolved type
  • Type something to narrow down your search
  • Note how the type information is lost from the search since it is automatically selected

This is really annoying UX.

The node catalogue is only temporary

Is it really? It is basically unchanged from its initial implementation for 2 years. See #2072.

Code

The node catalogue automatically focuses the input (this is desired):
https://github.com/GraphiteEditor/Graphite/blob/9f9899cfd0c2ddea4a8664358b6b1834f30adc66/frontend/src/components/floating-menus/NodeCatalog.svelte#L110-L111
When the focus is changed, the text input automatically selects all the text (not desired)
https://github.com/GraphiteEditor/Graphite/blob/9f9899cfd0c2ddea4a8664358b6b1834f30adc66/frontend/src/components/widgets/inputs/TextInput.svelte#L31-L35

Dominant language
Rust
Stars
27.3k
Forks
1.3k
Avg merge
1d 7h
Merged PRs (30d)
54

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from GraphiteEditor/Graphite

All issues in GraphiteEditor/Graphite

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.