Tangent on Path node unclear output

Open Beginner friendly
#4,275 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Quiet
Tech stack
rust
Domain
documentation

Research direction

Find the Tangent on Path node and its tooltip text, then verify how the node exposes its angle output. Clarify that the result is an angle in degrees, state that it is measured clockwise from the +X axis, and distinguish it from a unit-vector output. Done when the tooltip removes these ambiguities without changing node behavior.

Written by the indexing model from the issue text.

Description

The « Tangent on Path » node returns an angle in degrees clockwise from the +X axis. However this is really not clear. The tooltip states:

Determines the angle of the tangent at a point on the path, given by its progression from 0 to 1 along the path.
If multiple subpaths make up the path, the whole number part of the progression value selects the subpath and the decimal part determines the position along it.

The angle of the tangent of a bézier curve is often expressed as a unit vector such as on Pomax's bezierinfo. It is very easy for a user to assume that this might be the case (I did). This is especially true since non connected nodes do not get type hints about the output type. It is also possible that they do not know from where the angle is measured since it is never stated. Also why clockwise? I generally see anticlockwise from +X in e.g. argument of complex number.

Dominant language
Rust
Stars
27.3k
Forks
1.3k
Avg merge
1d 7h
Merged PRs (30d)
54

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from GraphiteEditor/Graphite

All issues in GraphiteEditor/Graphite

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.