Python constructor calls do not reach the initializer they run
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start with the Python call-graph construction and change-impact traversal, then inspect PR #4208, which describes the proposed constructor-entry edge and its scope. Reproduce the supplied fixture with graphify update and graphify affected; compare the graph before and after, including incremental output against a clean rebuild. Done means constructor calls reach the inferred initializer and callers while preserving all existing nodes and edges and respecting the documented static-analysis limitations.
Written by the indexing model from the issue text.
Description
Python constructor calls stop at the class node, hiding the initializer's dependencies from change-impact traversal.
Reproduction on current v8
Verified on v0.9.80, commit 6478eb7, with Python 3.13 on Linux. Build these files with graphify update <fixture> --no-cluster:
# pkg/storage.py
def open_db(path):
return path
class Store:
def __init__(self, path):
self.db = open_db(path)
# pkg/cache.py
from pkg.storage import Store
class CachedStore(Store):
pass
# pkg/service.py
from pkg.cache import CachedStore
def build(path):
return CachedStore(path)
# tests/test_service.py
from pkg.service import build
def test_build():
build("test.db")
graphify affected "open_db()" --depth 4 --graph <fixture>/graphify-out/graph.json finds Store.__init__ but misses build() and test_build(). The call graph has build -> CachedStore and Store.__init__ -> open_db, with no call edge joining them.
Constructor fix
PR #4208 adds an inferred constructor-entry edge when a supported source binding and class chain identify the initializer. It preserves the class edge and every other existing node and edge. The fixture then reaches the initializer, build(), its importing test file, and test_build(). Incremental output after editing the caller matches a clean rebuild.
Fresh comparisons against 6478eb7 add 703 constructor edges across seven pinned repositories: Flask 3, requests 3, httpx 56, rich 506, langchain-core 100, yt-dlp 17 and FastAPI 18. All 703 agree with an independent Python ast derivation. All 586 that SCIP can judge agree on the called class, inheritance chain and initializer. Every pre-existing node and edge remains identical.
This is a restricted static subset. Decorators, metaclasses, custom allocation, multiple inheritance, ambiguous bindings, external bases and known mutation patterns add no edge. Cross-module dynamic mutation remains a documented limitation.
Why it matters for test impact
A separate runtime-trace study measured Flask and yt-dlp tests against pinned source revisions. Historical v8 graphs reached only 4 of 3,482 sampled Flask test/function pairs and 20 of 606 yt-dlp pairs. A broader prototype combining receiver typing, constructor entry and pytest fixture dependencies reached 1,699 and 358 respectively. Those are historical prototype results, not the results of this constructor PR or current v0.9.80.
Constructor entry is one missing link in that chain. Since the study, upstream has added self.attr.method() support in #4176 and annotated/constructor-bound local receiver support in #4198. Those changes are already present in the base used to verify this PR. Remaining opportunities include inherited methods, factory return types and pytest fixture dependency edges through the nearest conftest.py chain.
Related: #2041, #2860, #2417, #2586 and #1499.
- Dominant language
- Python
- Stars
- 124k
- Forks
- 11.9k
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Graphify-Labs/graphify
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Graphify-Labs/graphify#3763 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Graphify-Labs/graphify#3611 · 1 comment ·
Maintainers usually reply within 1 day
-
Nix supportOpen
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Graphify-Labs/graphify#3193 · 2 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Graphify-Labs/graphify#2871 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Graphify-Labs/graphify#2865 ·
Maintainers usually reply within 1 day
All issues in Graphify-Labs/graphify
Similar issues
-
area: agents area: docs good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
openapi/gknowledge#23 ·
-
get() for StrEnumPossibly taken @FeJo5952 claimed this today. Opengood first issue
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
collective/icalendar#1921 · 1 comment ·
Maintainers usually reply within 1 day
-
Improvement Python Spans
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
getsentry/sentry-python#7994 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
alphagov/notifications-api#5004 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
equinor/radix-flux#3922 ·
Maintainers usually reply within 1 day