display of issue numbers / descriptors / etc.

Open
  • Is something wrong?
#483 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
django, python
Domain
web-dev

Research direction

Start by surveying the existing places on the website that combine issue numbers, volume numbers, variant names, and issue titles, then read how the generic tables based on django-tables are used. The issue does not name specific files or tests; done means ad-hoc displays are replaced step by step with well-defined routines that account for separate columns and the additional catalog number.

Written by the indexing model from the issue text.

Description

What we display after the series name can consist of:

  1. issue number
  2. (sometimes) volumes number
  3. variant name
  4. issue title
    and now
  5. (for a small number of issues) the mass market paperback catalog number for better issue identification.

We do have in different places of our website different ways to combine from 1-4 something to display. This used to be quite ad-hoc and at each place somewhat differently, but this is not maintainable. So step-by-step the different ad-hoc displays need to be replaced by generic routines, doing different kind of combinations of the above.

We will need several different routines that have a well defined way of combining these. E.g. sometimes we show issue title in a separate column from the issue number. Same for issue title. This needs to be taken into account.

This interacts with using more and more generic tables based on django-tables to show lists.

Dominant language
Python
Stars
122
Forks
36
Avg merge
2d 16h
Merged PRs (30d)
28

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from GrandComicsDatabase/gcd-django

All issues in GrandComicsDatabase/gcd-django

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.