Remove IVRBackend interface and call XRIT logic directly

Open
#521 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
52/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp, unity
Domain
game-dev

Research direction

Search the source for IVRBackend, HVR, and XRIT references, then read the interface and its implementations to identify the lookup path. Remove the abstraction and route those calls to XRIT directly, updating affected references and tests. Done when no obsolete HVR or IVRBackend references remain and the project builds and relevant tests pass.

Written by the indexing model from the issue text.

Description

improvement

Description

In the past we used HVR and XRIT together. To have an option switching between both, we added an interface to have both. As XRIT is now stable and HVR is removed from the source code itself, we can remove this abstraction to speed up lookup costs at runtime and also sanitize source code.

Dominant language
C#
Stars
33
Forks
1
Avg merge
2d 4h
Merged PRs (30d)
76

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Gothic-Unity-Project/Gothic-Unity

All issues in Gothic-Unity-Project/Gothic-Unity

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.