feat(ci): prepare trusted-main Go Race cache integration

Closed
  • Is something wrong?
#2,207 0 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@dnlrsls is already working on this.

Since Oct 30, 2026.

  • #2194 by @dnlrsls — merged

Assessment

This issue has not been assessed yet.

Description

status:approved type:feature
Existing Issue Search
  • I searched existing issues and will add evidence to a canonical tracker when applicable.

Parent #2192 owns measured Go-job feedback and cache effectiveness. Bounded searches for its preparatory slice and Race cache trackers found no existing child. This issue deliberately does not replace the parent or claim measured savings.

🔍 Observed Consequence

The existing Race-cache PR #2194 can exercise a cold pull-request path, but its trusted-main-only writer cannot demonstrate main cache publication and later compatible reuse before integration. Treating that preparatory change as completion of #2192 would close the measurement work without the required results.

💡 Desired Outcome

A separately accountable, reviewed preparatory integration makes the existing compatibility-scoped Race cache policy available on trusted main while #2192 remains open for actual main save/restore, transfer overhead and before/after feedback measurements. Maintainers can distinguish delivery of the preparation from proof of a performance benefit.

📦 Affected Area

Other (CI, Go Race cache ownership and contributor verification evidence).

Release Context

Not release-specific. Existing PR #2194, head 335072422dfbfe80422539530b0bb5e5e60636d4, against canonical main a6f66c2ea21f6ec2fcec4b4d6d54c576bb069897.

🔄 Workarounds and Constraints

The maintainer explicitly approved this child integration scope and retaining #2192 open for measurement. Do not weaken the trusted-main writer guard to make a fork demonstrate publication. Keep all existing suites, permissions, events, compatibility identity, deadlines, assertions and required contexts. Existing Windows failures remain tracked under #1891 and are not waived by this acceptance.

📎 Additional Context

Accepted preparatory scope and non-goals:

  • One explicit pinned cache restore/save owner in the Race job; no setup-go cache owner in that job.
  • Complete image, Go, target, dependency and compiler compatibility identity, with the tested revision appended to refresh immutable populations.
  • Cache publication only after a successful canonical-main push miss. PRs, forks, merge groups, failures and cancellations must not save.
  • Preserve unrelated jobs, full execution, reporting, permissions and time budgets. No dependency installation or administrative/ruleset changes.
  • This child covers preparation only. Main archive publication, compatible subsequent refresh, restore isolation, transfer/storage cost and net speedup stay pending on #2192; no performance guarantee or parent closure.

Existing evidence, not newly rerun here:

  • PR body records actual test-first RED, focused 37/37 and affected 62/62 Node passes, eight extracted-shell identity/error-path outcomes, and the later baseline correction's 731 passing policy checks with negative drift controls.
  • The hosted Race job passed on its synthetic PR merge with an explicit cache miss and save skipped. This proves cold PR execution/no-save, not trusted-main publication or savings.
  • Independent source/security verification and native review of the original cache unit are recorded in #2194. Any candidate change still requires its applicable current-candidate checks and review; an old approval is not universal authority.

Acceptance before queue:

  • #2194 closes this preparatory child, not #2192, and accurately states pending measurement.
  • Exact candidate retains the accepted writer/identity/execution invariants with applicable independent review evidence.
  • Current-head required checks pass; applicable failures and skipped reviews are explicitly accounted for without bypass.
  • A finite owned measurement follow-through remains on #2192 after integration.

The authenticated maintainer owns this slice. Approval of this scope is separate from passing CI, native consent, publication proof, Windows disposition and queue admission.

Dominant language
Go
Stars
7.1k
Forks
729
Avg merge
10h 12m
Merged PRs (30d)
272

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Gentleman-Programming/engram

All issues in Gentleman-Programming/engram

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.