feat(store): carry `org` through the passive-capture write path
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 68/100
Research direction
Start by locating PassiveCaptureParams in internal/store/ and read pull request #1151 to see the exact pattern for adding org to AddObservation. Mirror that: add the Org field with the .engram/config.json inheritance used by mem_save and mem_session_summary, then extend the passive dedup lookup (currently normalized_hash + project). internal/store/relations.go is the optional, lower-priority follow-up. Done means passive captures in org-scoped repos carry an org tag and appear in org-filtered searches; run the internal/store tests to confirm.
Written by the indexing model from the issue text.
Description
Follow-up to #1151, split out to keep that PR reviewable.
The passive-capture write path does not carry org: PassiveCaptureParams has no Org field, and its dedup lookup matches on normalized_hash + project only. Observations captured passively in an org-scoped repo therefore land without an org tag and do not surface in org-filtered searches or project listings.
Bringing it in line would mean threading org through PassiveCaptureParams (with the same .engram/config.json inheritance mem_save and mem_session_summary use) and adding it to the passive dedup identity, mirroring what #1151 does for AddObservation.
Related, lower priority: the memory-conflict-surfacing subsystem (internal/store/relations.go) also matches candidates by project + scope without org, so same-project observations from different orgs can still be flagged against each other. Pre-existing behavior, untouched by #1151.
- Dominant language
- Go
- Stars
- 7.1k
- Forks
- 729
- Avg merge
- 11h 17m
- Merged PRs (30d)
- 334
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Gentleman-Programming/engram
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Gentleman-Programming/engram#1899 ·
Maintainers usually reply within 1 day
-
status:needs-review type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Gentleman-Programming/engram#1687 ·
Maintainers usually reply within 1 day
-
priority:medium status:needs-review type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Gentleman-Programming/engram#863 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
Gentleman-Programming/engram#1900 ·
Maintainers usually reply within 1 day
-
status:needs-review type:bug
Difficulty 3/5 1-2 days Newbie friendliness 70/100
Gentleman-Programming/engram#1897 ·
Maintainers usually reply within 1 day
All issues in Gentleman-Programming/engram
Similar issues
-
area: watch bug priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
mariadb-operator/mariadb-operator#1962 ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
eugenioenko/ttt#919 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
QuantumNous/new-api#7839 ·
Maintainers usually reply within 1 day
-
bug needs-triage service/costoptimizationhub
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
hashicorp/terraform-provider-aws#50507 · 1 comment ·
Maintainers usually reply within 1 day