bug(ts3server): change-password does not apply the new password

Open
#5,237 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
66/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
bash, shell
Domain
cli, tooling

Research direction

Start with command_ts3_server_pass.sh, where ts3serverpass and parms are set before restart, then compare against the current start command that reads startparameters instead. Read the referenced refactor and start-parameter changes to see how one-off start arguments are passed. Done means change-password either applies serveradmin_password through startparameters for that start or the command is removed, verified manually against a TeamSpeak 3 server.

Written by the indexing model from the issue text.

Description

engine: null game: Teamspeak 3

Description

./<server> change-password (command_ts3_server_pass.sh) never applies the new ServerAdmin password.

The module sets ts3serverpass="1" and parms="serveradmin_password=... inifile=..." and then restarts the server. Nothing reads either variable any more:

  • parms was renamed to startparameters (#3151, #3340). The start command only uses startparameters.
  • The code that read ts3serverpass was removed in "refactor: remove legacy code" (069e3bd4e).

So the server restarts normally and the module still prints "New password applied".

Possible fixes

  • Pass serveradmin_password=... through startparameters for the one start, then restore it.
  • Or remove the command if it is no longer used.

Needs a TeamSpeak 3 server to test.

Found while sweeping for typos in #5236.

Dominant language
Shell
Stars
4.9k
Forks
866
Avg merge
17h 58m
Merged PRs (30d)
100

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from GameServerManagers/LinuxGSM

All issues in GameServerManagers/LinuxGSM

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.