bug(ts3server): change-password does not apply the new password
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 66/100
Research direction
Start with command_ts3_server_pass.sh, where ts3serverpass and parms are set before restart, then compare against the current start command that reads startparameters instead. Read the referenced refactor and start-parameter changes to see how one-off start arguments are passed. Done means change-password either applies serveradmin_password through startparameters for that start or the command is removed, verified manually against a TeamSpeak 3 server.
Written by the indexing model from the issue text.
Description
Description
./<server> change-password (command_ts3_server_pass.sh) never applies the new ServerAdmin password.
The module sets ts3serverpass="1" and parms="serveradmin_password=... inifile=..." and then restarts the server. Nothing reads either variable any more:
parmswas renamed tostartparameters(#3151, #3340). The start command only usesstartparameters.- The code that read
ts3serverpasswas removed in "refactor: remove legacy code" (069e3bd4e).
So the server restarts normally and the module still prints "New password applied".
Possible fixes
- Pass
serveradmin_password=...throughstartparametersfor the one start, then restore it. - Or remove the command if it is no longer used.
Needs a TeamSpeak 3 server to test.
Found while sweeping for typos in #5236.
- Dominant language
- Shell
- Stars
- 4.9k
- Forks
- 866
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 100
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from GameServerManagers/LinuxGSM
-
command: update-lgsm distro: Debian engine: source2 game: Counter-Strike 2 regression: yes reproducible: always severity: low type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
GameServerManagers/LinuxGSM#5242 ·
Maintainers usually reply within 1 day
-
distro: Debian distro: Ubuntu engine: spark game: Natural Selection 2 priority: high scope: single game type: feature
Difficulty 4/5 3-5 days Newbie friendliness 45/100
GameServerManagers/LinuxGSM#5241 ·
Maintainers usually reply within 1 day
-
command: send distro: Ubuntu engine: spark game: Natural Selection 2 priority: high scope: single game type: feature
Difficulty 4/5 3-5 days Newbie friendliness 48/100
GameServerManagers/LinuxGSM#5240 ·
Maintainers usually reply within 1 day
-
command: monitor distro: Ubuntu engine: spark game: Natural Selection 2 info: query reproducible: unable severity: critical type: bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
GameServerManagers/LinuxGSM#5238 ·
Maintainers usually reply within 1 day
-
command: install command: monitor command: start priority: medium scope: all servers type: feature
Difficulty 3/5 1-2 days Newbie friendliness 68/100
GameServerManagers/LinuxGSM#5204 ·
Maintainers usually reply within 1 day
All issues in GameServerManagers/LinuxGSM
Similar issues
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
varnish/helm-varnish#173 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
📦 Update Request
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
cdnjs/packages#2225 · 1 comment ·
Maintainers usually reply within 3 days
-
good first issue help wanted testing
Difficulty 1/5 Under an hour Newbie friendliness 78/100