Saving a second edit silently reverts the tags saved in the first edit
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 65/100
Research direction
Start by locating the track Rename flow and reading how it loads and saves tag values. Reproduce the reported sequence: save an album change, reopen Rename, change only the title, and save. Verify the track file's tags after each save; done means the second save preserves the album change as well as the new title.
Written by the indexing model from the issue text.
Description
Checklist
- I can reproduce the bug with the latest version given here.
- I made sure that there are no existing issues - open or closed - to which I could contribute my information.
- I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
- I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
- I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
- This issue contains only one bug.
- I have read and understood the contribution guidelines.
Affected app version
1.8.1 (version code 14)
Affected Android/Custom ROM version
Android 14 (API 34)
Affected device model
xiaomi 14
How did you install the app?
F-Droid / IzzyOnDroid
Steps to reproduce the bug
- I used Rename on a track to set its Album and saved it - the new album showed up in the list.
- I opened Rename on the same track again to fix the title as well.
- I changed only the title and saved.
- When I looked at the track afterwards, the album was back to its old value - my first edit was gone, without any warning.
Expected behavior
Every save should keep the values I entered before. Editing the title must not undo the album I saved a moment earlier.
Actual behavior
The second save wrote the old album back. I checked the file itself, not just the app: the album tag had reverted to the original value while the title kept my new one. I repeated it on a few tracks and the album reverts every single time; sometimes the artist or title revert too. Nothing warns me and there is no undo, so edits silently disappear.
Screenshots/Screen recordings
Additional information
I'm on Fossify Music Player 1.8.1, Android 14. I was tidying up the tags of my library; after this I stopped editing because I could not tell which of my edits had actually stuck. (I first thought the first save had failed, so I re-did it - that is what caused the revert.) I also looked at the file's tags outside the app: after the first save the album tag was "HB Album One", and after the second save it was back to "Downloaded" while the title kept my new value - so the second save really did write the old album over it.
- Dominant language
- Kotlin
- Stars
- 933
- Forks
- 104
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 17
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from FossifyOrg/Music-Player
-
feature request needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
FossifyOrg/Music-Player#479 ·
Maintainers usually reply within 1 day
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
FossifyOrg/Music-Player#424 · 1 reaction ·
Maintainers usually reply within 1 day
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
FossifyOrg/Music-Player#423 · 1 comment ·
Maintainers usually reply within 1 day
-
Add info button on current playing fileMay be free again A pull request for this issue was closed without being merged. Openfeature request needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
FossifyOrg/Music-Player#29 · 13 comments ·
Maintainers usually reply within 1 day
-
bug needs triage
Difficulty 3/5 1-2 days Newbie friendliness 45/100
FossifyOrg/Music-Player#499 · 2 comments ·
Maintainers usually reply within 1 day
All issues in FossifyOrg/Music-Player
Similar issues
-
[Submission] 悠悠有品Opensubmit-adaption submit-adaption-pre
Difficulty 1/5 Under an hour Newbie friendliness 75/100
BetterAndroid/android-notification-icon-project#763 · 1 comment ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
scarif-labs/horus#61 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 87/100
damontecres/Wholphin#2093 ·
Maintainers usually reply within 1 day
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
FossifyOrg/Messages#929 ·
Maintainers usually reply within 1 day
-
cr:missing-repro cr:platform:android missing-repro platform:android
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
software-mansion/react-native-screens#4950 · 1 comment ·
Maintainers usually reply within 1 day