Adopt shared mapper test data from engine-test-data
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 42/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- java
- Domain
- testing-qa
Research direction
Start with EngineMappers.java around line 444 and compare its identity override virtual segment key generation with the PHP and .NET references. Review engine-test-data pull request 46 and run the mapper_test_cases. Done means the shared cases pass and key generation matches the JSON plus SHA256 portable standard.
Written by the indexing model from the issue text.
Description
Mapper tests use inline expected context data rather than shared test cases from engine-test-data repository.
Acceptance criteria
- mapper_test_cases pass (see Flagsmith/engine-test-data#46)
- Identity override virtual segment key generation matches cross-SDK portable standard (JSON + SHA256)
Technical context
Current implementation uses non-portable hash:
https://github.com/Flagsmith/flagsmith-java-client/blob/b9097558fa83824068382457d944b721c206d01e/src/main/java/com/flagsmith/mappers/EngineMappers.java#L444
Portable standard (JSON + SHA256):
- PHP: https://github.com/Flagsmith/flagsmith-php-client/pull/124/files#diff-5872f438d0e149e75ba3660c6b8e7ec8af446b87ea6a4e70f45f7e8e9e7b9c4dR208
- .NET: https://github.com/Flagsmith/flagsmith-dotnet-client/pull/177/files#diff-f851c822fa0e162b75312b6b9ab5dc31d3631179a33360ec77bbb83f4ae7c50eR249
Shared test data: https://github.com/Flagsmith/engine-test-data/pull/46
Related issues:
- Flagsmith/flagsmith-python-client#181
- Flagsmith/flagsmith-ruby-client#93
- Flagsmith/flagsmith-nodejs-client#228
- Flagsmith/flagsmith-go-client#196
- Flagsmith/flagsmith-rust-flag-engine#26
- Flagsmith/flagsmith-dotnet-client#180
- Dominant language
- Java
- Stars
- 28
- Forks
- 22
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Flagsmith/flagsmith-java-client
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
-
Dependency Dashboard Open
Difficulty 4/5 3-5 days Newbie friendliness 15/100
-
Dependency Resolution: org.apache.maven:maven-artifact resolving org.codehaus.plexus:plexus-utils Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
All issues in Flagsmith/flagsmith-java-client
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
infinispan/infinispan#18150 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
opensearch-project/k-NN#3597 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100