Key type of `Map` valued properties not being added to Schema
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- java
- Domain
- backend-api-design
Research direction
Start in MapVisitor.java at the keyFormat(JsonFormatVisitable handler, JavaType keyType) callback and trace how the resulting JsonSchema object represents Map-valued properties. Determine how enum, time/date, and numbers-as-Strings key information is currently represented, then verify that the generated schema exposes the relevant key type information.
Written by the indexing model from the issue text.
Description
Looks like MapVisitor.java is not doing anything with key type it gets via callback:
@Override
public void keyFormat(JsonFormatVisitable handler, JavaType keyType)
throws JsonMappingException {
// JSON Schema only allows String types so let's not bother too much
}
but it should, since there is some useful information from databinding perspective (enum, time/date types, numbers-as-Strings) and this should be available from JsonSchema object.
- Dominant language
- Java
- Stars
- 387
- Forks
- 138
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from FasterXML/jackson-module-jsonSchema
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
FasterXML/jackson-module-jsonSchema#160 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
pr-needed
Difficulty 3/5 1-2 days Newbie friendliness 30/100
FasterXML/jackson-module-jsonSchema#136 · 10 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
FasterXML/jackson-module-jsonSchema#135 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
FasterXML/jackson-module-jsonSchema#134 · 2 comments · 1 reaction ·
All issues in FasterXML/jackson-module-jsonSchema
Similar issues
-
human-required sync-failed
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Azure/osdu-spi-file#63 ·
Maintainers usually reply within 1 day
-
frontend quick win
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
CodeForPhilly/benefit-decision-toolkit#571 ·
Maintainers usually reply within 1 day
-
approved
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
checkstyle/checkstyle#22129 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Add Hardcharger JDBC driverPossibly taken @prmoore77 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day