`TomlGenerator` writes date/time values without seconds (`LocalTime.of(10, 0)` as `10:00`)
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 20/100
Research direction
Read TomlGenerator.writePOJO() and compare its handling of LocalTime, LocalDateTime, and OffsetDateTime with the expected ISO format stated in the issue. The issue proposes PR #759, which is already open; review that work to understand the expected behavior. Done means these values include seconds when zero and remain valid for strict TOML 1.0 readers.
Written by the indexing model from the issue text.
Description
(split off from #758, item 4; found while reviewing #757; present on 3.x)
TomlGenerator.writePOJO() uses toString() for LocalTime / LocalDateTime / OffsetDateTime, which drops zero seconds: LocalTime.of(10, 0) is written as t = 10:00. TOML 1.0 requires seconds; this module's parser accepts it, but strict readers do not.
Expected: use ISO_LOCAL_TIME / ISO_LOCAL_DATE_TIME / ISO_OFFSET_DATE_TIME (or explicit patterns that always include seconds).
Proposed fix: PR #759.
- Dominant language
- Java
- Stars
- 454
- Forks
- 176
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 16
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from FasterXML/jackson-dataformats-text
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
FasterXML/jackson-dataformats-text#741 · 1 comment ·
Maintainers usually reply within 1 day
-
yaml
Difficulty 3/5 1-2 days Newbie friendliness 58/100
FasterXML/jackson-dataformats-text#754 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
FasterXML/jackson-dataformats-text#733 ·
Maintainers usually reply within 1 day
-
yaml
Difficulty 3/5 1-2 days Newbie friendliness 48/100
FasterXML/jackson-dataformats-text#661 · 6 comments ·
Maintainers usually reply within 1 day
-
yaml
Difficulty 5/5 Over a week Newbie friendliness 25/100
FasterXML/jackson-dataformats-text#612 · 1 comment ·
Maintainers usually reply within 1 day
All issues in FasterXML/jackson-dataformats-text
Similar issues
-
Cleanup: restore the interrupt flag in AiFailureAnalyzerPossibly taken @Rishankgupta08 claimed this today. Opengood first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seleniumboot/selenium-boot#258 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
dense-analysis/ale#5181 ·
-
bug subsystem:agent-harness triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
ShaftHQ/SHAFT_ENGINE#8043 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
johanhaleby/occurrent#1505 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day